Assign cart to customer as part of login mutation #1765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3108753 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
bookernath
force-pushed
the
cart-on-login-mutation
branch
from
72e39e2 to
2643cf5
Compare
bookernath
force-pushed
the
cart-on-login-mutation
branch
from
2643cf5 to
a2f9cb1
Compare
chanceaclark
approved these changes
Dec 16, 2024
bookernath
force-pushed
the
cart-on-login-mutation
branch
from
f000add to
b0ce62a
Compare
jorgemoya
approved these changes
Dec 17, 2024
bookernath
force-pushed
the
cart-on-login-mutation
branch
from
b0ce62a to
3108753
Compare
⚡️🏠 Lighthouse reportLighthouse ran against https://catalyst-latest-bqmt11nkf-bigcommerce-platform.vercel.app 🖥️ DesktopWe ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:
📱 MobileWe ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why?
Use the new enhancement to the
login()mutation to assign the guest cart to the customer at the moment of login, which avoids an extra GQL request for this and simplifies the code.A similar enhancement is coming soon to logout but will be a separate PR.
Testing
Preview deployment
Screen.Recording.2024-12-16.at.4.22.45.PM.mov