-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): use amount and discounts fields for cart summary #659
Conversation
🦋 Changeset detectedLatest commit: 8bef691 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
It looks like the Grand Total in your screenshot isn't taking into account the discounts, is that correct? |
df1989c
to
5da9820
Compare
5da9820
to
dd05327
Compare
f0e03ee
to
42d3567
Compare
⚡️🏠 Lighthouse reportWe ran Lighthouse against the changes and produced this report. Here's the summary:
Lighthouse ran against https://catalyst-latest-6zkpx78l1-bigcommerce-platform.vercel.app/ |
Fixed by using |
What/Why?
Discount was not showing in cart for a marketing promotion. Noticed we were using the
discountedAmount
for each specific line item instead of the global discounted amount value.Testing
Locally