fix(storefront): BCTHEME-143 Improper heading hierarchy on PLPs

bigcommerce · Aug 12, 2020 · 16520c5 · 16520c5
1 parent 353c9c8
commit 16520c5
Show file tree

Hide file tree

Showing 9 changed files with 14 additions and 12 deletions.
diff --git a/assets/scss/components/foundation/accordion/_accordion.scss b/assets/scss/components/foundation/accordion/_accordion.scss
@@ -21,6 +21,7 @@
 }
 
 .accordion-title {
+    font-size: remCalc(15px);
     margin: 0;
 }
 

diff --git a/assets/scss/layouts/sidebar/_block.scss b/assets/scss/layouts/sidebar/_block.scss
@@ -16,6 +16,7 @@
 }
 
 .sidebarBlock-heading {
+    font-size: remCalc(15px);
     margin-top: 0;
     text-transform: inherit;
 }
diff --git a/templates/components/category/shop-by-price.html b/templates/components/category/shop-by-price.html
@@ -1,6 +1,6 @@
 {{#and theme_settings.shop_by_price_visibility shop_by_price}}
     <div class="sidebarBlock">
-        <h5 class="sidebarBlock-heading">{{lang 'category.shop_by_price'}}</h5>
+        <h2 class="sidebarBlock-heading">{{lang 'category.shop_by_price'}}</h2>
         <ul class="navList">
             {{#each shop_by_price}}
             <li class="navList-item">

diff --git a/templates/components/category/sidebar.html b/templates/components/category/sidebar.html
@@ -1,7 +1,7 @@
 <nav>
     {{#if category.subcategories}}
         <div class="sidebarBlock">
-            <h5 class="sidebarBlock-heading">{{category.name}}</h5>
+            <h2 class="sidebarBlock-heading">{{category.name}}</h2>
             <ul class="navList">
                 {{#each category.subcategories}}
                 <li class="navList-item">

diff --git a/templates/components/faceted-search/facets/hierarchy.html b/templates/components/faceted-search/facets/hierarchy.html
@@ -4,9 +4,9 @@
         class="accordion-navigation toggleLink {{#unless ../start_collapsed }} is-open {{/unless}}"
         role="button"
         data-collapsible="#facetedSearch-content--{{#replace '&' (hyphenate facet) }}{{else}}{{hyphenate facet}}{{/replace}}">
-        <h5 class="accordion-title">
+        <h2 class="accordion-title">
             {{ title }}
-        </h5>
+        </h2>
 
         <div class="accordion-navigation-actions">
             {{#if selected}}

diff --git a/templates/components/faceted-search/facets/multi.html b/templates/components/faceted-search/facets/multi.html
@@ -4,9 +4,9 @@
         class="accordion-navigation toggleLink {{#unless ../start_collapsed }} is-open {{/unless}}"
         role="button"
         data-collapsible="#facetedSearch-content--{{#replace '&' (hyphenate facet) }}{{else}}{{hyphenate facet}}{{/replace}}">
-        <h5 class="accordion-title">
+        <h2 class="accordion-title">
             {{ title }}
-        </h5>
+        </h2>
 
         <div class="accordion-navigation-actions">
             {{#if selected}}

diff --git a/templates/components/faceted-search/facets/range.html b/templates/components/faceted-search/facets/range.html
@@ -3,9 +3,9 @@
         class="accordion-navigation toggleLink {{#unless start_collapsed }} is-open {{/unless}}"
         role="button"
         data-collapsible="#facetedSearch-content--{{hyphenate facet }}">
-        <h5 class="accordion-title">
+        <h2 class="accordion-title">
             {{ title }}
-        </h5>
+        </h2>
 
         <div class="accordion-navigation-actions">
             {{#if selected}}

diff --git a/templates/components/faceted-search/facets/rating.html b/templates/components/faceted-search/facets/rating.html
@@ -4,9 +4,9 @@
         class="accordion-navigation toggleLink {{#unless ../start_collapsed }} is-open {{/unless}}"
         role="button"
         data-collapsible="#facetedSearch-content--{{hyphenate facet }}">
-        <h5 class="accordion-title">
+        <h2 class="accordion-title">
             {{ title }}
-        </h5>
+        </h2>
 
         <div class="accordion-navigation-actions">
             {{#if selected}}

diff --git a/templates/components/faceted-search/selected-facets.html b/templates/components/faceted-search/selected-facets.html
@@ -1,7 +1,7 @@
 <div class="facetedSearch-refineFilters sidebarBlock">
-    <h5 class="sidebarBlock-heading">
+    <h2 class="sidebarBlock-heading">
         {{lang 'search.faceted.selected.title'}}
-    </h5>
+    </h2>
 
     {{#if this.items}}
         <ul class="inlineList inlineList--labels">