fix(content): STRF-4948 fix missing svg icons on AMP add-to-cart page…

… by generating an template file that contains the assets
bigcommerce · Jun 13, 2018 · 35cebc7 · 35cebc7
1 parent 140103a
commit 35cebc7
Show file tree

Hide file tree

Showing 7 changed files with 10 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,7 @@
 - Fix empty image on carousel wrap. [#1263](https://github.com/bigcommerce/cornerstone/pull/1263)
 - Fix duplicate IDs occurrence in product options in certain situations & syntax fix in bulk-discount-rates component [#1223](https://github.com/bigcommerce/cornerstone/pull/1223)
 - Fix use case that prevented retail/sale prices from displaying on product details page [#1262](https://github.com/bigcommerce/cornerstone/pull/1262)
+- Fix svg arrows missing on AMP product pages. [#1258](https://github.com/bigcommerce/cornerstone/pull/1258)
 
 ## 2.1.0 (2018-06-01)
 - Add Newsletter summary section to subscription form. [#1248](https://github.com/bigcommerce/cornerstone/pull/1248)

diff --git a/assets/icons/instagram.svg b/assets/icons/instagram.svg
diff --git a/assets/icons/stumbleupon.svg b/assets/icons/stumbleupon.svg
diff --git a/assets/img/icon-sprite.svg b/assets/img/icon-sprite.svg
diff --git a/grunt/svgstore.js b/grunt/svgstore.js
@@ -7,7 +7,8 @@ module.exports = {
 
     'default': {
         files: {
-            './assets/img/icon-sprite.svg': ['./assets/icons/**/*.svg']
+            './assets/img/icon-sprite.svg': ['./assets/icons/**/*.svg'],
+            './templates/components/amp/common/icon-defs.html': ['./assets/icons/**/*.svg']
         }
     }
 };
diff --git a/templates/components/amp/common/icon-defs.html b/templates/components/amp/common/icon-defs.html
diff --git a/templates/layout/amp-iframe.html b/templates/layout/amp-iframe.html
@@ -24,7 +24,7 @@
         </style>
     </head>
     <body>
-        <svg data-src="{{cdn 'icons/icons.svg'}}" class="icons-svg-sprite"></svg>
+        <div class="icons-svg-sprite">{{> components/amp/common/icon-defs }}</div>
 
         {{#block "page"}} {{/block}}