Merge pull request #1362 from sacr3dc0w/breadcrumbs

Fix errors in breadcrumb schema markup
bigcommerce · Oct 8, 2018 · 47729bc · 47729bc
2 parents 06181d1 + 5db3fe5
commit 47729bc
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,7 @@
 # Changelog
 
 ## Draft
+- Fix broken breadcrumb schema markup [#1362](https://github.com/bigcommerce/cornerstone/pull/1362)
 
 ## 2.5.0 (2018-09-26)
 - Blueprint for Mapping Custom Templates to JavaScript Modules [#1346](https://github.com/bigcommerce/cornerstone/pull/1346)

diff --git a/templates/components/common/breadcrumbs.html b/templates/components/common/breadcrumbs.html
@@ -2,8 +2,9 @@
     {{#each breadcrumbs}}
         <li class="breadcrumb {{#if @last}}is-active{{/if}}" itemprop="itemListElement" itemscope itemtype="http://schema.org/ListItem">
             {{#if url}}
-                <a href="{{url}}" class="breadcrumb-label" itemprop="item">{{name}}</a>
+                <a href="{{url}}" class="breadcrumb-label" itemprop="item"><span itemprop="name">{{name}}</span></a>
             {{else}}
+                <meta itemprop="item" content="{{url}}">
                 <span class="breadcrumb-label" itemprop="name">{{name}}</span>
             {{/if}}
             <meta itemprop="position" content="{{@index}}" />