Skip to content

Commit

Permalink
Merge pull request #1585 from bc-williamkwon/fixProductReviews
Browse files Browse the repository at this point in the history
STRF-7487 fix registerValidation function to always validate on writeReview-form email field
  • Loading branch information
bc-williamkwon authored Oct 14, 2019
2 parents d6f9141 + 6cd4925 commit da17f17
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## Draft
- Added missing gift certificate translation
- Fix registerValidation function to validate on writeReview-form email field [#1585](https://github.com/bigcommerce/cornerstone/pull/1585)

## 4.2.0 (2019-10-02)
- Fixes and some additions to our Google Structured Data schema for the product page template [#1577](https://github.com/bigcommerce/cornerstone/pull/1577)
Expand Down
2 changes: 1 addition & 1 deletion assets/js/theme/product/reviews.js
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ export default class {
validate: 'presence',
errorMessage: this.context.reviewComment,
}, {
selector: '[name="email"]',
selector: '.writeReview-form [name="email"]',
validate: (cb, val) => {
const result = forms.email(val);
cb(result);
Expand Down

0 comments on commit da17f17

Please sign in to comment.