Skip to content

Commit

Permalink
BCTHEME-160: add valid ARIA role for Related Products tab (#1782)
Browse files Browse the repository at this point in the history
Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>
  • Loading branch information
bc-alexsaiannyi and BC-tymurbiedukhin authored Aug 26, 2020
1 parent d358566 commit ea9fab1
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Changelog

## Draft
- Added a valid ARIA role for li elemenents on "Related Products" tab [#1782](https://github.com/bigcommerce/cornerstone/pull/1782)
- Fixed IDs used in ARIA and labels which are not unique. [#1791](https://github.com/bigcommerce/cornerstone/pull/1791)
- Button inputs with the same name attribute should be part of a group. [#1792](https://github.com/bigcommerce/cornerstone/pull/1792)
- Fixed Shop by price insufficient link text. [#1786](https://github.com/bigcommerce/cornerstone/pull/1786)
Expand Down
4 changes: 2 additions & 2 deletions templates/components/products/tabs.html
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
<ul class="tabs" data-tab role="tablist">
{{#if product.related_products}}
<li class="tab is-active" role="presentational">
<li class="tab is-active" role="presentation">
<a class="tab-title" href="#tab-related" role="tab" tabindex="0" aria-selected="true" controls="tab-related">{{lang 'products.related_products'}}</a>
</li>
{{/if}}
{{#if product.similar_by_views}}
<li class="tab{{#unless product.related_products}} is-active{{/unless}}" role="presentational">
<li class="tab{{#unless product.related_products}} is-active{{/unless}}" role="presentation">
<a class="tab-title" href="#tab-similar" role="tab" tabindex="0" aria-selected="{{#if product.related_products}}false{{else}}true{{/if}}" controls="tab-similar">{{lang 'products.similar_by_views'}}</a>
</li>
{{/if}}
Expand Down

0 comments on commit ea9fab1

Please sign in to comment.