Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handlebars command causes pages to timeout #1115

Open
Tiggerito opened this issue Nov 2, 2017 · 1 comment
Open

Handlebars command causes pages to timeout #1115

Tiggerito opened this issue Nov 2, 2017 · 1 comment

Comments

@Tiggerito
Copy link
Contributor

Expected behavior

This command:

{{occurrences '|default|product|blog_post|' (concat page_type '|')}}
Should detect if the page is of one of the page types.

Actual behavior

it causes the page to time out.

Steps to reproduce behavior

Add the command to a page and then view it.

Note that these commands work fine:

{{occurrences '|default|product|blog_post|' page_type}}

{{concat page_type '|'}}

It only happens when they are combined.

@ghost
Copy link

ghost commented Apr 12, 2019

@Tiggerito As of now occurrences is expecting to receive substring of a type String. concat helper returns SafeString and I think that it cause the issue. We will check if we can change concat to return String.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant