change concat to return a string #156
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattolson
suggested changes
Jul 16, 2019
| @@ -6,8 +6,13 @@ | |||
| * {{@lang (concat 'products.reviews.rating.' this) }} | |||
| */ | |||
| function helper(paper) { | |||
| paper.handlebars.registerHelper('concat', function (value, otherValue) { | |||
| return new paper.handlebars.SafeString(value + otherValue); | |||
| paper.handlebars.registerHelper('concat', function (value, otherValue, returnSafeString = true) { | |||
There was a problem hiding this comment.
I would rename this parameter to returnUnsafe and default it to false, which will preserve existing behavior.
| @@ -0,0 +1,4917 @@ | |||
| { | |||
There was a problem hiding this comment.
We shouldn't check in this file since this is a library included by other applications.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently concat returns safeString. We are not sure if we receive safe string into the method. We might turn a safe string that will be escaped into an unsafe one string that won’t be checked before display, allowing malicious code injection.
We have an issue open related to contact returned value (bigcommerce/cornerstone#1115):
{{occurrences '|default|product|blog_post|' (concat page_type '|')}}
occurrences expects to receive a string but since concat return safe string the method cause timeout.