Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home page carousel data is pre-HTML escaped #1292

Open
carsonreinke opened this issue Jun 28, 2018 · 5 comments
Open

Home page carousel data is pre-HTML escaped #1292

carsonreinke opened this issue Jun 28, 2018 · 5 comments

Comments

@carsonreinke
Copy link
Contributor

Expected behavior

Stencil object Home Slide Show should return heading, text, and button_text as unescaped raw data. This allows actual template to decide if data should be HTML entity escaped or not.

Actual behavior

Stencil object is returned with data already HTML escaped. Use of Handlebars {{ }} produces double escaped HTML and {{{ }}} produces single HTML escaped output.

Steps to reproduce behavior

Adding any HTML entities to Home Page Carousel content within the BigCommerce Admin under Storefront > Home Page Carousel > Slide 1 > Button Text. Current template file uses a mix of Handlebars escaping: https://github.com/bigcommerce/cornerstone/blob/master/templates/components/carousel-content.html

@junedkazi
Copy link
Contributor

@carsonreinke can you open a PR to address the issue. I will be happy to review it.

@carsonreinke
Copy link
Contributor Author

@junedkazi Unfortunately, this is external to what can be resolved within Cornerstone. The actual Stencil object has this problem. Support suggested I post it here.

@NjTheCoder
Copy link
Contributor

@carsonreinke I am also seeing this issue

@Ubersmake
Copy link
Contributor

Thanks all for raising this. I've written up an engineering ticket to follow up.

@satyasaadhak
Copy link

Was this ever resolved? I am facing this same issue right now. I want to insert some spans in the carousel slide content, but it just shows up as it is isn't of being rendered as a DOM element.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants