Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Countries with symbols & punctuation in the name are not encoding #1341

Merged
merged 1 commit into from
Sep 5, 2018
Merged

Countries with symbols & punctuation in the name are not encoding #1341

merged 1 commit into from
Sep 5, 2018

Conversation

hellojakesmith
Copy link
Contributor

@hellojakesmith hellojakesmith commented Sep 5, 2018

This is fixing the country name options entities on the account signup form.
This fix is for Cornerstone / Other themes will need to be updated by 3rd parties such as Pixel Union
https://jira.bigcommerce.com/browse/STRF-5396

Countries with symbols & punctuation in the name are not encoding, for example:
"Cote d'Ivoire"

updated theme file template/components/common/forms/select.html

-Line 11 Was: <option {{#if selected}} selected {{/if}} value="{{value}}">{{label}}
screen shot 2018-09-05 at 12 49 06 pm

-Line 11 Now Is: <option {{#if selected}} selected {{/if}} value="{{value}}">{{{label}}}
screen shot 2018-09-05 at 12 47 02 pm

@bigcommerce/storefront-team

@bigbot
Copy link

bigbot commented Sep 5, 2018

Autotagging @bigcommerce/storefront-team @davidchin

@junedkazi junedkazi changed the title Strf 5396 Countries with symbols & punctuation in the name are not encoding Sep 5, 2018
@junedkazi junedkazi merged commit 72e2cc7 into bigcommerce:master Sep 5, 2018
@carsonreinke
Copy link
Contributor

Related to #1292, data is already HTML encoded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants