-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Product carousels no longer adjust to smaller displays on 'Similar' and 'New Products' #1391
Comments
Hi, data-slick='{ with data-slick='{ in /templates/components/products/carousel.html And we didn't face any issues related to browser. Note: |
Thanks @HikeOn . Yep, that fixed it for me too. 👍 |
Hi @itsViney and @HikeOn . Thanks for writing and commenting on this issue. We're working on a better carousel solution for Cornerstone. I'd like to keep this issue open until we do. For context, this is related to #1389 and #1371. #1371 was released with Cornerstone 2.5.2, and reflects what's happening in this ticket, which @HikeOn caught: https://github.com/bigcommerce/cornerstone/pull/1371/files#diff-339911808b202005e03163613b83868aL6 #1389, which as of this comment hasn't been released yet, is only a band-aid fix for word wrap issues. |
@Ubersmake I would recommend glide if you are looking for a plugin solution - be happy to make a pr. |
@Ubersmake please also consider modifying to use |
Expected behavior
As with the 'Featured' and 'Top Products' carousels on the home page and as they did in previous versions of Cornerstone, the 'Similar Products' carousel on the product page and the 'New Products' carousel on the home page should adapt properly to smaller displays.
I believe this issue was introduced in 2.6.0. These carousels behaved as expected in previous versions.
Actual behavior
Unlike the other carousels, these two always display 5 columns of product cards, causing them to text to overlap and thumbnails becoming too small to be of use when views on narrow screens such as mobile devices.
Other carousels automatically wrap if the cards' width goes below ~200px. The 'Similar Products' and 'New Products' carousels should do the same
Steps to reproduce behavior
The text was updated successfully, but these errors were encountered: