STRF-5651: Break product card titles on overflow. #1389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Autotagging @bigcommerce/storefront-team @davidchin |
mattolson
approved these changes
Nov 30, 2018
bookernath
approved these changes
Nov 30, 2018
|
Is it possible to make this hyphenate word breaks? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Changes to the New Products carousel in 2.5.2 changed how many products appeared as the view width became narrower and narrower. Specifically, it would always try to honor the number of columns set for the theme. This means that products with long words get less and less space as the view narrows, and particularly long words start overflowing into adjacent columns.
This change forces words to break if they hit the edge of the column.
This has also been verified to not crash Mobile Safari, which was the reason for #1371 in the first place.
Tickets / Documentation
Screenshots (if appropriate)
Before:
After: