CRO-139: group logo properties #1012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adambilsing
force-pushed
the
CRO-139
branch
4 times, most recently
from
9be13bc
to
88a4d8c
Compare
junedkazi
approved these changes
May 17, 2017
lord2800
reviewed
May 17, 2017
config.json
Outdated
| @@ -70,6 +70,8 @@ | |||
| "product_list_display_mode": "grid", | |||
| "logo-position": "center", | |||
| "logo_size": "250x100", | |||
| "logo_fontSize": 12, | |||
There was a problem hiding this comment.
We'll need to add some code to the template and/or the css to make use of this new value too.
adambilsing
force-pushed
the
CRO-139
branch
5 times, most recently
from
1cccb8e
to
9af4857
Compare
|
💚 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Consolidate logo properties.
Tickets / Documentation
Testing / Images
@bigcommerce/cp-dt