Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product Images obscure product details on smaller viewports #1019

Merged
merged 1 commit into from
Jun 27, 2017
Merged

Product Images obscure product details on smaller viewports #1019

merged 1 commit into from
Jun 27, 2017

Conversation

sacr3dc0w
Copy link
Contributor

@sacr3dc0w sacr3dc0w commented Jun 14, 2017

Product image obscures product details when scaling down the viewport.

What?

A minimum width and height of 366px solves the overlap issue. Setting
display to initial as an alternative solution breaks product zoom.

Tickets / Documentation

See issue #966

Screenshots

The red border is just for demonstration purposes.

display: initial breaking out of container
Initial

Before
Before

After
After

@junedkazi
Copy link
Contributor

@mcampa

@PreciselyAlyss PreciselyAlyss requested a review from mcampa June 22, 2017 17:07
@PreciselyAlyss PreciselyAlyss merged commit d1b98a1 into bigcommerce:master Jun 27, 2017
@sacr3dc0w sacr3dc0w deleted the product-image-overlap branch June 27, 2017 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants