Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHECKOUT-1671 Use different id for gift cert in cart page #1044

Merged
merged 1 commit into from
Jul 19, 2017
Merged

CHECKOUT-1671 Use different id for gift cert in cart page #1044

merged 1 commit into from
Jul 19, 2017

Conversation

RobinOng
Copy link
Contributor

@RobinOng RobinOng commented Jul 18, 2017 •
edited
Loading

What?

IDs not unique in Shopping Cart for Coupon Code & Gift Certificate (they both use id=”couponcode”)

Why?

Make IDs to be unique for accessibility

Tickets / Documentation

https://jira.bigcommerce.com/browse/CHECKOUT-1671

Screenshots (if appropriate)

Before:

  • Coupon code:

screen shot 2017-07-18 at 4 57 31 pm

  • Gift certificate:

screen shot 2017-07-18 at 4 56 33 pm

After:

  • Gift certificate:

screen shot 2017-07-18 at 4 51 21 pm

junedkazi
junedkazi suggested changes Jul 18, 2017
View reviewed changes
Copy link
Contributor

@junedkazi junedkazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a change log entry to CHANGELOG.md under draft

@RobinOng RobinOng force-pushed the CHECKOUT-1671 branch 3 times, most recently from 0dac347 to 9dc203a Compare July 19, 2017 00:31
@RobinOng
Copy link
Contributor Author

Thanks @junedkazi . Added to the change log.

@junedkazi junedkazi merged commit 941f912 into bigcommerce:master Jul 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junedkazi junedkazi junedkazi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RobinOng @junedkazi