Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use {{template_file}} as parameter in window.stencilBootstrap #1049

Closed
wants to merge 1 commit into from
Closed

Use {{template_file}} as parameter in window.stencilBootstrap #1049

wants to merge 1 commit into from

Conversation

sacr3dc0w
Copy link
Contributor

@sacr3dc0w sacr3dc0w commented Jul 22, 2017

What?

{{template}} comes up as undefined in window.stencilBootstrap() [#1032] , preventing product options from loading on custom templates, so restoring the use of {{template_file}} for the time being.

Tickets / Documentation

547b511#commitcomment-23057333

Screenshots

{{template_file}}
1-options

{{template}}
2-no-options

@sacr3dc0w sacr3dc0w changed the title Use {{template_file}} as parameter in window.Bootstrap Use {{template_file}} as parameter in window.stencilBootstrap Jul 22, 2017
@mcampa
Copy link
Contributor

mcampa commented Jul 24, 2017

This is a bug. We need to investigate. {{template}} should always be defined

@mcampa
Copy link
Contributor

mcampa commented Jul 24, 2017

Ok, we need to revert the entire PR #1032

@mcampa
Copy link
Contributor

mcampa commented Jul 24, 2017

This PR addresses the issue #1050

@mcampa mcampa closed this Jul 24, 2017
@sacr3dc0w sacr3dc0w deleted the tmpl-prod-options branch July 24, 2017 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants