STENCIL-3380: Adds auto height to alternative nav menu and submenus. #1056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junedkazi
reviewed
Jul 31, 2017
| @@ -320,7 +321,7 @@ | |||
| @include breakpoint("medium") { | |||
| border-left: 1px solid stencilColor("navPages-subMenu-separatorColor"); | |||
| display: inherit; | |||
| height: $navPage-subMenu-horizontal-height; | |||
There was a problem hiding this comment.
Is this variable being used anywhere else ? Or can we remove the definition as well completely ?
There was a problem hiding this comment.
I didn't see that it was being used anywhere else but was hesitant to remove it myself. If you think it's best, I can go ahead with it.
There was a problem hiding this comment.
Instead of removing this variable please change the value of the variable to auto, in assets/scss/settings/stencil/navPages/_settings.scss
There was a problem hiding this comment.
... and yes, it is only used here
There was a problem hiding this comment.
Will do. Thanks, Mario.
There was a problem hiding this comment.
Got the changes made. Need to squash my commits still. Will do so in the morning :)
junedkazi
approved these changes
Jul 31, 2017
junedkazi
approved these changes
Aug 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This change ensures the alternative navigation menu and its submenus always have the proper background length no matter how many categories a merchant has.
Tickets / Documentation
https://jira.bigcommerce.com/browse/STENCIL-3380
Screenshots (if appropriate)
Before/After for Main Menu:
https://www.screencast.com/t/Dueilwqbp
Before/After for Submenus:
https://www.screencast.com/t/qOgJbQnM