-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STENCIL-3559 403 error message #1057
Conversation
lang/en.json
Outdated
"message": "You do not have permission to access this page." | ||
"page_heading": "Sorry! Please log in to continue", | ||
"message": "You do not have permission to access this page. If you were logged in, ", | ||
"sign_in": "please sign in" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you were logged in, please sign in
does not make sense to me. Is this the actual copy or this is going to change ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry! Please log in to continue
If you were logged in, please log back in
to resume your work in a new session.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I think it is missing to resume your work in a new session.
?
65845c5
to
e59a50b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nickdengler just a heads up this might break tests which are validating 403 along with the content.
Thanks, I have a PR ready with the fix for this. When this goes out, we'll need to merge it at the same time. |
Change the 403 page message to be more friendly
https://jira.bigcommerce.com/browse/STENCIL-3559
before
after
@bigcommerce/stencil-team