Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STENCIL-3383 Do not show add to cart on disabled products. #1063

Merged
merged 3 commits into from
Aug 14, 2017

Conversation

junedkazi
Copy link
Contributor

@junedkazi junedkazi commented Aug 11, 2017

What?

This PR fixes a couple of things;

  • In list view do not show "Add to Cart" on Storefront when Products are Disabled for Purchase.
  • Added the "Pre order" cart action as it was missing.
  • Fix the bug where the buttons were getting slightly cut off
  • Updated "choose options" to not be a primary option to match grid view
  • Login for pricing in list view
  • Add to cart url for pre-order products since it was just redirecting to product detail page

Tickets / Documentation

https://jira.bigcommerce.com/browse/STENCIL-3383
https://jira.bigcommerce.com/browse/STENCIL-3353

Screenshots (if appropriate)

Before

screen shot 2017-08-11 at 9 49 37 am

After

Pre order

screen shot 2017-08-11 at 9 47 16 am

options

screen shot 2017-08-11 at 9 47 05 am

disabled online ordering

screen shot 2017-08-11 at 9 46 57 am

Add to cart

screen shot 2017-08-11 at 9 46 51 am

Login for pricing in list view

screen shot 2017-08-11 at 10 34 42 am

@bigcommerce/stencil-team @bc-ranji @cristycarpenter

@junedkazi junedkazi force-pushed the STENCIL-3383-list-view branch from 51eb385 to 9e5de44 Compare August 11, 2017 17:08
@bc-ranji
Copy link
Contributor

💚

@@ -43,7 +43,7 @@
<a href="{{url}}" class="button button--small card-figcaption-button" data-product-id="{{id}}">{{lang 'products.choose_options'}}</a>
{{/if}}
{{#if pre_order}}
<a href="{{url}}" class="button button--small card-figcaption-button">{{lang 'products.pre_order'}}</a>
<a href="{{pre_order_add_to_cart_url}}" class="button button--small card-figcaption-button">{{lang 'products.pre_order'}}</a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a new field?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes it will be a new fields which will only be passed for pre-order. On product details page it is a form so it is not required on those pages. But on pages where it is a card it is necessary bcoz earlier it was taking users to product detail pages. It is a similar url construct to add to cart.

Copy link
Contributor

@mjschock mjschock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just need to resolve the merge conflict

@junedkazi junedkazi force-pushed the STENCIL-3383-list-view branch from 751634b to f55b397 Compare August 14, 2017 17:42
@junedkazi junedkazi merged commit 4cb9784 into bigcommerce:master Aug 14, 2017
@junedkazi junedkazi deleted the STENCIL-3383-list-view branch August 14, 2017 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants