Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSON LD Schema to breadcrumbs #1079

Closed
wants to merge 1 commit into from

Conversation

abrambailey
Copy link

This is currently missing from Cornerstone. Please implement.

@PreciselyAlyss
Copy link
Contributor

@abrambailey Thanks for the pull request!

Can you provide more details about the expected behavior and how to test the changes?

A What/Why/How to test format is great :)

@abrambailey
Copy link
Author

@PreciselyAlyss Please confirm expected behavior for any page with breadcrumbs by copy pasting the page url or the html source into https://search.google.com/structured-data/testing-tool/u/0/

This is correct behavior:

image

Why? Because it helps Google understand your content, and SEO optimization, etc.

Copy link
Contributor

@davidchin davidchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @abrambailey, I think you saw this already #1045. Can you please switch to use Microdata instead of RDFa JSON-LD? Thanks!

@abrambailey
Copy link
Author

@davidchin JSON LD is Google's preferred form of schema markup. Not sure why you guys aren't using it?

@davidchin
Copy link
Contributor

Hey @abrambailey, thanks for your explanation. Yeah I'm aware of the fact that Google currently prefers JSON-LD for various reasons. I think it wasn't their preference when we first started building this theme. Back then, it wasn't very well supported; search engines such as Bing didn't support it at all. And it seems it's still not supported by Bing and other less sophisticated search engines.

On the other hand, Microdata is supported by most search engines because it has been around for a long time and it's just plain HTML attributes. Google also doesn't penalise the use of Microdata and it can parse it just as well as JSON-LD. Although I agree JSON-LD has many advantages over Microdata, but I think for now, Microdata is a better choice.

In the future, if JSON-LD becomes far superior or widely supported, or Microdata becomes deprecated, we are open to switch to JSON-LD. In that case, I'd like to make an effort to switch all structured data to JSON-LD, instead of just doing it ad-hoc, so that everything is consistent.

I know you put in some effort making this work. Sorry about that. Would it take long for you to update this PR so that it fits our current choice for structured data?

@abrambailey
Copy link
Author

Thanks @davidchin that makes sense. I suppose I haven't really been too worried about Bing, etc.. so missed that before. Don't worry about the work I put in, I am able to use the JSON-LD for my project, which is what matters. I just thought I'd do the PR to save you all some trouble. Good luck :)

@mjschock
Copy link
Contributor

mjschock commented Mar 1, 2018

closing in favor of #1175

@mjschock mjschock closed this Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants