CATALOG-1447 - Update product cards to use price ranges #1143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjschock
reviewed
Jan 4, 2018
| @@ -1,3 +1,35 @@ | |||
| {{#with price_range}} | |||
| {{min.formatted}} - {{max.formatted}} | |||
| {{/with}} | |||
| {{#and price_range.min.with_tax price_range.max.with_tax}} | |||
There was a problem hiding this comment.
since we're using a {{#with price_range}} above we can do {{#and min.with_tax max.with_tax}} instead and {{#and}} seems fine to me
There was a problem hiding this comment.
Thanks, will update
|
Autotagging @bigcommerce/storefront-team @davidchin |
|
Screenshot from integration:
|
bookernath
changed the title
bookernath
changed the title
bookernath
changed the title
junedkazi
reviewed
Jan 9, 2018
| {{#and price_range.min.without_tax price_range.max.without_tax}} | ||
| <abbr title="{{lang 'products.excluding_tax'}}">{{lang 'products.price_with_tax' tax_label=price_range.min.tax_label}}</abbr> | ||
| {{else if schema_org}} | ||
| <meta itemprop="availability" content="{{product.availability}}"> |
There was a problem hiding this comment.
I am wondering if it makes sense to move the meta into a price schema component.
junedkazi
reviewed
Jan 9, 2018
-Remove "as low as" feature -Add new "price range" boolean theme editor setting, defaulting to true, to display ranges -Augment price component to support ranges if available and enabled -Update schema.org to use PriceSpecification so that we can correctly support ranges and also inc tax/exc tax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
-Remove "as low as" feature (no longer needed with price ranges)
-Add new "price range" boolean theme editor setting, defaulting to true, to display ranges
-Augment price component to support ranges if available and enabled (graceful fallback for stores not enabled)
-Update schema.org to use PriceSpecification so that we can correctly support ranges and also inc tax/exc tax
Tickets / Documentation
Add links to any relevant tickets and documentation.
Screenshots (if appropriate)
Other important notes