Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STRF-4390: Fix event delegation error #1151

Merged
merged 1 commit into from
Jan 19, 2018
Merged

STRF-4390: Fix event delegation error #1151

merged 1 commit into from
Jan 19, 2018

Conversation

mjschock
Copy link
Contributor

@mjschock mjschock commented Jan 19, 2018 •
edited
Loading

What?

  • there was a bug where the modals weren't closing due to the stop propagation call which was wired incorrectly.

Tickets

Before/After

Before

After

@bigcommerce/storefront-team

@bigbot
Copy link

bigbot commented Jan 19, 2018

Autotagging @bigcommerce/storefront-team @davidchin

@mjschock mjschock merged commit 36ddd54 into bigcommerce:master Jan 19, 2018
@mjschock mjschock deleted the STRF-4390 branch January 19, 2018 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattolson mattolson mattolson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mjschock @bigbot @mattolson