STRF-4373: Removing lazyload for logo in order-confirmation.html #1159
Conversation
|
Autotagging @bigcommerce/storefront-team @davidchin |
jfasanobc
changed the title
|
@mjschock just making sure you saw this PR bcoz there is a ticket assigned to you for this sprint. |
| @@ -16,7 +16,7 @@ <h1 class="is-srOnly">{{lang 'checkout.title'}}</h1> | |||
| <h2 class="checkoutHeader-heading"> | |||
| <a class="checkoutHeader-link" href="{{urls.home}}"> | |||
| {{#if checkout.header_image}} | |||
| <img alt="{{settings.store_logo.title}}" class="checkoutHeader-logo lazyload" id="logoImage" data-sizes="auto" src="{{cdn 'img/loading.svg'}}" data-src="{{ checkout.header_image }}"/> | |||
| <img alt="{{settings.store_logo.title}}" class="checkoutHeader-logo" id="logoImage" src="{{ checkout.header_image }}"/> | |||
There was a problem hiding this comment.
I am fine with this change but instead of removing the lazy load we should be investigating what is causing the failure to load in the first place.
There was a problem hiding this comment.
True, I was just looking at a quick solution for now, as it's only this and another page from a previous PR. I tried researching it a bit, but it was bit over my head as to why. Thanks for reviewing, I wasn't sure as to why it wouldn't let me add reviewers.
There was a problem hiding this comment.
Do we support running theme scripts on the order confirmation page? I believe the lazysizes script just isn't being inserted there, despite being part of global.js. Assuming that's the case, this is quite possibly the correct solution, short of manually inserting a <script> tag in the order confirmation template.
There was a problem hiding this comment.
I am guessing that is what is happening as well.
|
i'm going to go ahead a merge this - we'll create a separate ticket to pull out the shared code between the checkout and order-confirmation pages. i was thinking of something like a common checkout partial where we pass the down |
What?
The image for the order-confirmation.html was not loading, and as with the issue in STRF-4138, I've removed the lazyload for the logo for this template page.
Tickets / Documentation
Add links to any relevant tickets and documentation.
Screenshots (if appropriate)
Before
After