-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(catalog): CATALOG-2913 individual low inventory count for skus #1234
Conversation
setting for skus. We were not properly switching back and forth between skus that were above and below their own respective threshholds.
Autotagging @bigcommerce/storefront-team @davidchin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Ubersmake Can you test this? |
@@ -463,6 +463,9 @@ export default class ProductDetails { | |||
// if the stock container is hidden, show | |||
viewModel.stock.$container.removeClass('u-hiddenVisually'); | |||
|
|||
viewModel.stock.$input.text(data.stock); | |||
} else { | |||
viewModel.stock.$container.addClass('u-hiddenVisually'); | |||
viewModel.stock.$input.text(data.stock); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this text be updating to be an empty string since the data.stock does not exist in this case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
turns it out does not matter....this is working as is
💚 this is working for me |
What?
address STOCK_LEVEL_DISPLAY_SHOW_WHEN_LOW
setting for skus. We were not properly switching back and forth
between skus that were above and below their own respective
threshholds.
Tickets / Documentation
Dependency
in order for this to work completely, this FE change depends on a BC pr
please see ticket for additional info.