Fix ESLint "no-console" warning #1237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Autotagging @bigcommerce/storefront-team @davidchin |
|
I'm not sure if it is preferred to disable the ESLint rule, or to remove the |
| @@ -70,6 +70,7 @@ export default class ProductDetails { | |||
| } | |||
| } | |||
| } catch (e) { | |||
| /* eslint-disable no-console */ | |||
| console.error(e); | |||
There was a problem hiding this comment.
Wouldn't it be more ideal to use console.error(e) // eslint-disable-line no-console? Just a preference on how we disable eslint modules for specific lines in projects on my end, so I could be absolutely wrong in how I'm using it.
There was a problem hiding this comment.
Sounds good. I've updated it.
mattolson
approved these changes
May 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR fixes the following issue:
Tickets / Documentation
N/A
Screenshots (if appropriate)
N/A