STRF-4701 - Additional fixes to address missing class names #1277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Autotagging @bigcommerce/storefront-team @davidchin |
bc-jz
force-pushed
the
STRF-4701-cont
branch
2 times, most recently
from
5d4b318
to
e26f641
Compare
…in PR review: indention correction and removing language file properties that are no longer being used in the template. fix(catalog): STRF-4701 - Found some tests breaking due to some missing class names. Updated class names in the pricing to make sure they are consistent among the various code paths. Made sure the "price saved" element is always present (but maybe not visible). Added some comments. A couple INPUT id parameter updates that were missed when LABEL elements were updated - caused product list to not function on PDP.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Some additional PDP pricing fixes to address missing class names so that they are more consistent, and some trivial formatting changes. The missing classes also broke tests so this should fix that. Tested such locally.
This is additional changes we found were needed during testing following:
#1262
Tickets / Documentation
STRF-4701