Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor ESLint errors in webpack.common.js #1280

Merged
merged 1 commit into from
Jun 29, 2018
Merged

Fix minor ESLint errors in webpack.common.js #1280

merged 1 commit into from
Jun 29, 2018

Conversation

sacr3dc0w
Copy link
Contributor

@sacr3dc0w sacr3dc0w commented Jun 21, 2018

What?

Just some minor cleanup for consistency in webpack.common.js by removing unnecessary quotes from single string properties and use single quotes for theme bundle output path. Added benefit of removing ESLint errors thrown in Atom.

  • Strings must use singlequote. (quotes) 45:39
  • Unnecessarily quoted property 'lazysizes' found. (quote-props) 63:13
  • Unnecessarily quoted property 'pace' found. (quote-props) 64:13

CHANGELOG.md Outdated
@@ -12,6 +12,7 @@
- Fix prices not showing in quick search while logged in when "Restrict to Login" for price display is true [#1272](https://github.com/bigcommerce/cornerstone/pull/1272)
- Display product reviews in tabbed content region of product page [#1273](https://github.com/bigcommerce/cornerstone/pull/1273)
- Fix duplicate input ID's in product review form [#1276](https://github.com/bigcommerce/cornerstone/pull/1276)
- Fix for ESLint "quotes" and "quote-props" errors. [#1280](https://github.com/bigcommerce/cornerstone/pull/1280)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sacr3dc0w can you just move this into the draft section please.

-Strings must use singlequote. (quotes) 45:39
-Unnecessarily quoted property 'lazysizes' found. (quote-props) 63:13
-Unnecessarily quoted property 'pace' found. (quote-props) 64:13
@junedkazi junedkazi merged commit 64010b7 into bigcommerce:master Jun 29, 2018
@sacr3dc0w sacr3dc0w deleted the late-spring-cleaning branch June 30, 2018 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants