Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix blog_post import statement in app.js #1301

Merged
merged 1 commit into from
Jul 31, 2018
Merged

Fix blog_post import statement in app.js #1301

merged 1 commit into from
Jul 31, 2018

Conversation

sacr3dc0w
Copy link
Contributor

@sacr3dc0w sacr3dc0w commented Jul 4, 2018 •
edited
Loading

app.js currently includes blog.js code on the blog_post page class, rather than blog-post.js code. This fixes that.

@bigbot
Copy link

bigbot commented Jul 4, 2018

Autotagging @bigcommerce/storefront-team @davidchin

junedkazi
junedkazi approved these changes Jul 5, 2018
View reviewed changes
Copy link
Contributor

@junedkazi junedkazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will have to wait for the next cornerstone release.

@junedkazi
Copy link
Contributor

@sacr3dc0w can we rebase this PR please ?

@Ubersmake Ubersmake merged commit b0231fe into bigcommerce:master Jul 31, 2018
@sacr3dc0w sacr3dc0w deleted the blog_post branch July 31, 2018 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junedkazi junedkazi junedkazi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sacr3dc0w @bigbot @junedkazi @Ubersmake