Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(catalog): MERC-3743 Fix zoom behavior for small images in gallery #1325

Merged
merged 1 commit into from
Aug 10, 2018

Conversation

kchu93
Copy link
Contributor

@kchu93 kchu93 commented Aug 7, 2018

What?

Fixed issue with Cornerstone product image zoom functionality. If images were too small (less than 500px), zoomed image would not show properly.

Solution: Set up a checkImage() function to check image size before easyzoom-flyout. If image is less than image container (~500px), easyzoom-flyout is hidden, else, easyzoom functions normally.

Tickets / Documentation

Add links to any relevant tickets and documentation.

Images / Gifs

Previous Zoom Function (bug)

Image of bug
previous zoom

Gif of bug
previouszoom

Current Zoom Function (Fix)

zoomfix

@bigbot
Copy link

bigbot commented Aug 7, 2018

Autotagging @bigcommerce/storefront-team @davidchin

@@ -2,6 +2,7 @@ import $ from 'jquery';
import 'easyzoom';
import _ from 'lodash';


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: extra whitespace

@Ubersmake
Copy link
Contributor

Ubersmake commented Aug 10, 2018

💚 . Please add before and after screenshots or GIFs to the description, as well as a Changelog entry under Draft.

@kchu93
Copy link
Contributor Author

kchu93 commented Aug 10, 2018

♻️

@Ubersmake Ubersmake merged commit b1b3eab into bigcommerce:master Aug 10, 2018
@kchu93 kchu93 deleted the MERC-3743 branch August 10, 2018 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants