Require Webpack config only when used #1334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junedkazi
suggested changes
Aug 22, 2018
stencil.conf.js
Outdated
| @@ -26,6 +22,9 @@ var watchOptions = { | |||
| * Watch any custom files and trigger a rebuild | |||
| */ | |||
| function development() { | |||
| var webpack = require('webpack'); | |||
There was a problem hiding this comment.
@jbruni can we just move the var webpack = require('webpack'); outside so we don't have to specify it for each env.
|
@jbruni can you also add a changelog entry please. |
jbruni
changed the title
|
@junedkazi - Requested changes have been done. 👍 |
junedkazi
approved these changes
Aug 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Detailed description has been written and discussed at issue bigcommerce/stencil-cli#379
This change helps to prevent that issue to happen, because the time to be ready for receiving messages from
stencil-cliis dramatically reduced.Tickets / Documentation