Added "activePage" as a active class in navigation menu #1335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge from Original Source
Merge Request
|
Autotagging @bigcommerce/storefront-team @davidchin |
|
active for pages? |
|
Hello @bigmadness For web pages, i am working on it and soon i will submit that too to cornerstone team. |
|
I have added the activePage class too for web pages. Please check. |
|
can anyone please let me know whether my changes are merged in cornerstone or not. Can i close this pull request if it is merged or not. |
|
@taruntds Thanks for submitting this! Our team will review the changes as soon as they have a moment. Once it's reviewed, we'll comment if there are any questions, or merge it, in which case the pull request would close automatically. |
junedkazi
suggested changes
Aug 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
activePage is a active class which will be applied when any page is active. For example. If you visit any category page then this "activePage" class will be activated and that particular category name will be highlighted in different color.