PAYMENTS-3071 Add the schema and config options for paypal smart button configuration #1359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @bigcommerce/merc-team Cornerstone schema changes |
|
@lord2800 Could you rebase and add a CHANGELOG entry? |
lord2800
force-pushed
the
PAYMENTS-3071
branch
from
5ec1de4 to
e2a0d76
Compare
|
Done. |
|
@BC-EChristensen @kchu93 let's please review this settings w SD |
|
I'm happy to explain how to get this to show up if needed. |
|
Hi @lord2800 I added this PR to our theme but it doesn't seem to work. Please check this screenshot: http://prntscr.com/l4ot21 |
|
The options aren't yet active. I'm still working on that part. |
|
are the options working yet? |
|
They are for Braintree, but not yet for PayPal. |
|
Thanks for the info! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This adds support for customizing the look and feel of the Paypal and Braintree checkout buttons on the cart (and other) pages. Some of the options are mutually exclusive, but there's currently no way to represent that in the schema--those mutually exclusive options will simply fail to render buttons on the page, so it falls on the merchant to discover that their payment buttons don't render and select options that do. This new section is hidden when the merchant does not have Paypal or Braintree enabled as a payment gateway.
Tickets / Documentation
Screenshots (if appropriate)