shotaK's Add context to the menu collapsible factory target elements #1382
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased version of #1299 by shotaK.
Testing
This has no effect on Cornerstone as it is, but benefits anyone extending Cornerstone.
To test, make the following changes:
Change
/assets/js/theme/global.js
so thatmenu()
is defined twice with two different contexts:Add something to
/templates/components/common/header.html
so that the second menu can be displayed:Add a new file for that new template being referenced,
templates/components/common/navigation-menu-2.html
. Note thesomething-else
, an attribute which is being used as a "tell" to verify that things are working as expected.With fix:
Notice how there are two menu bars, and the "duplicate" is correctly tagged with the
something-else
attribute.Without fix:
Only the first menu can be accessed here.
something-else
does not appear, and only the first menu is opened and interacted with while inspecting the DOM.And for good measure, Cornerstone 2.6.0 with the fix: