Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To set proper align Product thumbnail image slider arrows #1399

Merged
merged 1 commit into from
Jan 25, 2019
Merged

To set proper align Product thumbnail image slider arrows #1399

merged 1 commit into from
Jan 25, 2019

Conversation

NjTheCoder
Copy link
Contributor

What?

If a product has more then 5 images. It will create slider but there is an issue about align of the slider arrows.

Screenshots (if appropriate)

Before:
image

After:
image

To set proper align Product thumbnail image slider arrows
@bigbot
Copy link

bigbot commented Dec 7, 2018

Autotagging @bigcommerce/storefront-team @davidchin

Copy link
Contributor

@junedkazi junedkazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NjTheCoder have you tested the change across different device types like tablet, phones etc ?

Also can you add a changelog entry for the change.

Copy link
Contributor Author

@NjTheCoder NjTheCoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I have checked on all devices. This line for to fix arrow issue on product thumbnail images.

@Ubersmake Ubersmake merged commit 64a01e4 into bigcommerce:master Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants