Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed z-index for header to higher #1422

Merged
1 commit merged into from Jan 16, 2019
Merged

changed z-index for header to higher #1422

1 commit merged into from Jan 16, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jan 15, 2019

What?

Currently the sale badge floats above menu on mobile. This change should make the header class higher than sale badge and the badge won't floats above menu on mobile.

Screenshots (if appropriate)

Before

screen shot 2019-01-15 at 2 39 06 pm

screen shot 2019-01-15 at 2 39 51 pm

After

screen shot 2019-01-15 at 2 41 13 pm

screen shot 2019-01-15 at 2 41 19 pm

@bigbot
Copy link

bigbot commented Jan 15, 2019

Autotagging @bigcommerce/storefront-team @davidchin

@ghost ghost merged commit 9f28b36 into bigcommerce:master Jan 16, 2019
@ghost ghost deleted the sale_badge branch January 16, 2019 00:01
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants