Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STRF-4173 - Ensure SKU and UPC display correctly for Variants when th… #1431

Merged
merged 1 commit into from
Jan 24, 2019

Conversation

bc-jz
Copy link
Contributor

@bc-jz bc-jz commented Jan 23, 2019

…ey are not set on base product.

What?

For complex products, if you do not set SKU or UPC on the base product level, then the SKU/UPC will not display on the PDP and QuickView popup on PLP. These changes correct this issue ensuring that variant level SKU/UPC can always display on PDP and PLP.

The SKU/UPC label values will also now hide if there is not a SKU associated with the particular selection.

Tickets / Documentation

JIRA

Screenshots (if appropriate)

On my branch
Initial page load - there is not a SKU or UPC on base product:
2019-01-23_0759

Choosing selections that have a SKU and UPC set on Variant:
2019-01-23_0759-1

@bigbot
Copy link

bigbot commented Jan 23, 2019

Autotagging @bigcommerce/storefront-team @davidchin

Copy link
Contributor

@Ubersmake Ubersmake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please add an entry to CHANGELOG.md.

$upc: $('[data-product-upc]'),
sku: {
$dt: $('dt.sku-label', $scope),
$dd: $('[data-product-sku]', $scope),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we just name the keys as label and value so it is easier to read.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea I suppose so - was just following the format already in place

},
upc: {
$dt: $('dt.upc-label', $scope),
$dd: $('[data-product-upc]', $scope),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@bc-jz bc-jz merged commit 8f2010d into bigcommerce:master Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants