Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added package-lock.json #1441

Merged
merged 1 commit into from Feb 8, 2019
Merged

added package-lock.json #1441

merged 1 commit into from Feb 8, 2019

Conversation

ghost
Copy link

@ghost ghost commented Feb 7, 2019

What?

Added package-lock.json and checked to github, in order to have reproducible builds.

README.md Outdated Show resolved Hide resolved
README.md Outdated
@@ -102,6 +102,11 @@ and run:
npm install
```

* Note: package-lock.json file was generated by Node version 8 and npm version 6.4.1. Although the app supports Node versions 6 and 8 as well as multiple versions of npm, we should always use those versions when installing the package-lock.json, unless decided to upgrade those, and in this case the readme should be upadted as well. If using a different version for node OR npm, please delete the package-lock.json file prior installing the node packages and also prior pushing to github.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • "updating package-lock.json" instead of "installing the package-lock.json"
  • "unless it is decided"
  • typo: "upadted"
  • "prior to installing node packages" instead of "prior installing the node packages"
  • "prior to pushing to github"

README.md Outdated
@@ -102,6 +102,11 @@ and run:
npm install
```

* Note: package-lock.json file was generated by Node version 8 and npm version 6.4.1. Although the app supports Node versions 6 and 8 as well as multiple versions of npm, we should always use those versions when installing the package-lock.json, unless decided to upgrade those, and in this case the readme should be upadted as well. If using a different version for node OR npm, please delete the package-lock.json file prior installing the node packages and also prior pushing to github.

If updating or adding a dependency, please double check that you are working on Node version 8 and npm version 6.4.1 and run ```npm update <package_name>``` or ```npm install <package_name>``` (avoid running npm install for updating a package). After updating the package, please make sure that the changes in the package-lock.json reflecting only the updated/new package prior pushing the changes to github.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • "reflect only" instead of "reflecting only"
  • "prior to pushing the changes"

README.md Outdated Show resolved Hide resolved
@mattolson mattolson merged commit e77e420 into bigcommerce:master Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant