added package-lock.json #1441
Merged
added package-lock.json #1441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattolson
reviewed
Feb 7, 2019
mattolson
reviewed
Feb 8, 2019
README.md
Outdated
| @@ -102,6 +102,11 @@ and run: | |||
| npm install | |||
| ``` | |||
|
|
|||
| * Note: package-lock.json file was generated by Node version 8 and npm version 6.4.1. Although the app supports Node versions 6 and 8 as well as multiple versions of npm, we should always use those versions when installing the package-lock.json, unless decided to upgrade those, and in this case the readme should be upadted as well. If using a different version for node OR npm, please delete the package-lock.json file prior installing the node packages and also prior pushing to github. | |||
There was a problem hiding this comment.
- "updating package-lock.json" instead of "installing the package-lock.json"
- "unless it is decided"
- typo: "upadted"
- "prior to installing node packages" instead of "prior installing the node packages"
- "prior to pushing to github"
README.md
Outdated
| @@ -102,6 +102,11 @@ and run: | |||
| npm install | |||
| ``` | |||
|
|
|||
| * Note: package-lock.json file was generated by Node version 8 and npm version 6.4.1. Although the app supports Node versions 6 and 8 as well as multiple versions of npm, we should always use those versions when installing the package-lock.json, unless decided to upgrade those, and in this case the readme should be upadted as well. If using a different version for node OR npm, please delete the package-lock.json file prior installing the node packages and also prior pushing to github. | |||
|
|
|||
| If updating or adding a dependency, please double check that you are working on Node version 8 and npm version 6.4.1 and run ```npm update <package_name>``` or ```npm install <package_name>``` (avoid running npm install for updating a package). After updating the package, please make sure that the changes in the package-lock.json reflecting only the updated/new package prior pushing the changes to github. | |||
There was a problem hiding this comment.
- "reflect only" instead of "reflecting only"
- "prior to pushing the changes"
mattolson
reviewed
Feb 8, 2019
mattolson
approved these changes
Feb 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Added package-lock.json and checked to github, in order to have reproducible builds.