MERC-4566 Add option to hide breadcrumbs and page title

[kchu93]

What?

Add option to hide breadcrumbs, page heading, category heading, contact page heading and blog page heading.

Tickets / Documentation

MERC-4566

Turning off breadcrumbs

Turn off page heading

Turn off category page heading

Turn off contact page heading

Turn off blog page heading

Images

[bigbot]

Autotagging @bigcommerce/storefront-team @davidchin

[Tiggerito]

I think the terminology used here is confusing. Technically these are not page titles, but headings. In admin they are generally called page names.

And the Search Engine Optimisation sections use the term page title (correctly) for the title tag, which is a different thing.

I suggest you use "Hide page heading".

[kchu93]

After speaking with design, we want to be very clear with which page headings we want to turn off. I have added individual options (type 'page' heading, category heading, contact us heading, and blog heading)

[mattcoy-arcticleaf]

The names (id's) of the settings themselves are a bit confusing. I would think that a setting with an id of "breadcrumbs" would enable them if set to true, rather than the opposite being true, which is the case here. I would recommend changing the names to "hide_breadcrumbs", "hide_page_heading", etc.

From a code perspective, since you are only checking for a single item in the conditional statements, you do not need to use the "or" helper. A simple {{#if ../theme_settings.blog_page_heading '!==' true}}, would suffice. Also, since you are checking for an inverse, this can be written with even less code using an {{#unless}} helper. Finally, since the scope has not changed in these files (except in the case of the breadcrumbs where you put it inside the each loop), you do not need to add the '../', leaving the final code something like: {{#unless theme_settings.blog_page_heading }}code here{{/unless}}.

Note that in the case of the breadcrumbs, you would need to use the ../, or move the conditional outside the each block.

[kchu93]

@mattcoy-arcticleaf Thank you so much for the feedback, this was super helpful!