Resolve add to cart modal mobile isssue #1450
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This change brings the add to cart modal to the proper location on mobile.
On mobile screens, the add to cart modal appears off-screen. This issue stems from an edit made to the modal.scss file where the left, top, and transform CSS properties were removed.
To replicate, go to any product on the Cornerstone demo theme, for example, the Able Brewing System, resize your window to a width under 551px, and add the product to your cart.
The edit made to the modal.scss file appears to be a fix to center the small modal. This issue can be resolved by setting margin to 0, while keeping the left, top, and transform properties. I have changed the margin to 0 to prevent breaking the small modal with this edit.
Tickets / Documentation
N/A
Screenshots
Before:
After: