Clean up whitespace in layout/base.html #1513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The <head> of the storefront contains a bunch of empty stuff when you llook at it in prod - this removes some of that.
lord2800
reviewed
May 31, 2019
| @@ -11,7 +11,7 @@ | |||
| <meta name="viewport" content="width=device-width, initial-scale=1, maximum-scale=1"> | |||
|
|
|||
| <script> | |||
| // Change document class from no-js to js so we can detect this in css | |||
| {{!-- Change document class from no-js to js so we can detect this in css --}} | |||
There was a problem hiding this comment.
🙇 for this and the js --> handlebars comment below.
lord2800
approved these changes
May 31, 2019
junedkazi
approved these changes
May 31, 2019
|
Autotagging @bigcommerce/storefront-team @davidchin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The of the storefront contains a bunch of empty stuff when you llook at it in prod - this removes some of that which makes it a little easier to develop on Cornerstone.
Before
After