Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STRF-3591 add return instructions in return-saved.html #1525

Merged
merged 1 commit into from
Jun 28, 2019

Conversation

bc-williamkwon
Copy link
Contributor

@bc-williamkwon bc-williamkwon commented Jun 23, 2019

What?

Previously return instructions did not appear after submitting a return request and one would need to edit the template file in return-saved.html to display return instructions even if they had configured returns instructions in the control panel. This pull request is to fix that issue.

Tickets / Documentation

Add links to any relevant tickets and documentation.

Screenshots (if appropriate)

Attach images or add image links here.
image
image

@bigbot
Copy link

bigbot commented Jun 23, 2019

Autotagging @bigcommerce/storefront-team @davidchin

Copy link
Contributor

@bookernath bookernath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just need to make sure language is in a language file and add a changelog.

Thanks!

templates/pages/account/return-saved.html Outdated Show resolved Hide resolved
@bc-williamkwon bc-williamkwon changed the title STRF-3591 add return instructions STRF-3591 add return instructions in return-saved.html Jun 23, 2019
@bc-williamkwon bc-williamkwon force-pushed the returnInstructions branch 3 times, most recently from c8442a8 to ca28fc0 Compare June 23, 2019 22:54
bookernath
bookernath previously approved these changes Jun 24, 2019
bookernath
bookernath previously approved these changes Jun 27, 2019
Copy link
Contributor

@bookernath bookernath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase - otherwise this is good to go.

mattolson
mattolson previously approved these changes Jun 28, 2019
Copy link
Contributor

@mattolson mattolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but needs rebase

@bc-williamkwon
Copy link
Contributor Author

bc-williamkwon commented Jun 28, 2019

rebased.

@mattolson mattolson merged commit 0d295df into bigcommerce:master Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants