feat(search): ES-97 fixed the html special chars issue in facet names #1637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Autotagging @bigcommerce/storefront-team @davidchin |
bc-williamkwon
previously approved these changes
Feb 12, 2020
junedkazi
suggested changes
Feb 12, 2020
| @@ -30,7 +30,7 @@ <h5 class="accordion-title"> | |||
| class="navList-action navList-action--checkbox {{#if selected }} is-selected {{/if}}" | |||
| rel="nofollow" | |||
| data-faceted-search-facet> | |||
| {{ sanitize title }} | |||
| {{{ title }}} | |||
There was a problem hiding this comment.
We should also update the label across each of the facets.
| @@ -15,7 +15,7 @@ <h5 class="sidebarBlock-heading"> | |||
| {{#if facet '===' 'rating'}} | |||
| {{lang 'search.faceted.selected.rating-label' rating=title}} | |||
| {{else}} | |||
| {{ title }} | |||
| {{{ title }}} | |||
There was a problem hiding this comment.
I think we should do it across all these files https://github.com/bigcommerce/cornerstone/tree/master/templates/components/faceted-search/facets
There was a problem hiding this comment.
I have made changes to all applicable files. Please review them.
bc-krishsenthilraj
force-pushed
the
ES-97
branch
from
acf14cb
to
31bf694
Compare
junedkazi
previously approved these changes
Feb 12, 2020
bc-krishsenthilraj
force-pushed
the
ES-97
branch
from
31bf694
to
39d761d
Compare
junedkazi
previously approved these changes
Feb 12, 2020
lord2800
reviewed
Feb 13, 2020
| @@ -7,7 +7,7 @@ | |||
| rel="nofollow" | |||
| data-id="{{ id }}" | |||
| data-faceted-search-facet> | |||
| {{title}} | |||
| {{{title}}} | |||
There was a problem hiding this comment.
We should probably sanitize all of the titles--there's little to no reason anyone should be using html in a custom field or option value name or value.
There was a problem hiding this comment.
added them.. pls review it.
bc-krishsenthilraj
force-pushed
the
ES-97
branch
from
39d761d
to
a19e13e
Compare
junedkazi
approved these changes
Feb 13, 2020
asiejnapsc
added a commit
to asiejnapsc/SBM_Stencil_OLD_FORK
that referenced
this pull request
Mar 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
As part of fixing the encoding issues for ES-97, we found that html characters are being displayed in stencil theme. This fix will address it.
Tickets / Documentation
Screenshots (if appropriate)
Broken "RefineBy" facet names
Fixed "RefineBy" facet names