Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(catalog): CATALOG-5557 Special characters are not rendered for product review #1665

Merged
merged 2 commits into from
May 4, 2020
Merged

fix(catalog): CATALOG-5557 Special characters are not rendered for product review #1665

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9176820
fix(catalog): CATALOG-5557 Special characters are not rendered for pr…
Apr 30, 2020
9b3b404
fix(catalog): CATALOG-5557 Special characters are not rendered for pr…
May 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion templates/components/products/reviews.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ <h5 itemprop="name" class="productReview-title">{{ title }}</h5>
</p>
{{/if}}
</header>
<p itemprop="reviewBody" class="productReview-body">{{nl2br text}}</p>
<p itemprop="reviewBody" class="productReview-body">{{{ sanitize text }}}</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we please do the same for the review title as well

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I've done the same for the review title.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same issue is also present on facets

</article>
</li>
{{/each}}
Expand Down