feature(storefront): BCTHEME-68 Add tooltips for carousel "Previous" and "Next" buttons #1749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Autotagging @bigcommerce/storefront-team @davidchin |
Comment on lines
+24
to
+25
| if (lastSlide < 2) return; | ||
| if ($arrowLeft.length === 0 || $arrowRight.length === 0) return; |
There was a problem hiding this comment.
Can we concatenate conditions?
There was a problem hiding this comment.
Yes, but in this case I would like to have different conditions, because it is more obvious what cases are unsuitable for continuing function
BC-tymurbiedukhin
approved these changes
Aug 4, 2020
bc-alexsaiannyi
approved these changes
Aug 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
@BC-tymurbiedukhin @bc-alexsaiannyi
Carousel now has arrows with dynamic aria-labels. It tells the user on what exactly slide he will go when click on arrow, and how many slides in carousel. Also refactored code
Tickets / Documentation
Ticket
Screenshots (if appropriate)
left arrow init
right arrow init
left arrow after slide forward
right arrow after slide forward
Also I changed behaviour of products carousel a little bit (at the bottom of the homepage). Now click on arrow triggers moving slides by one. And carousel in a loop now. This is necessary for correct aria-labels of arrows. Or maybe we can use
"Previous" and "Next" for aria-labels in this carousel
product carousel now
product carousel before
