feature(storefront): BCTHEME-74 As a shopper I want to have the add to cart modal immediately have keyboard focus #1758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Autotagging @bigcommerce/storefront-team @davidchin |
BC-tymurbiedukhin
suggested changes
Aug 3, 2020
assets/js/theme/global/modal.js
Outdated
|
|
||
| const $collection = focusableElements[modalType](); | ||
| $collection.get(0).focus(); | ||
| this.modalSelector = modalSelector; |
There was a problem hiding this comment.
Thank you for changes, after that we don't need lane 235 as well
There was a problem hiding this comment.
thanks, working on it right now:)
BC-tymurbiedukhin
approved these changes
Aug 3, 2020
bc-alexsaiannyi
approved these changes
Aug 3, 2020
…o cart modal immediately have keyboard focus
BC-tymurbiedukhin
approved these changes
Aug 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
@BC-tymurbiedukhin @bc-alexsaiannyi
Now when user open a product details modal it has automatically focused on first element (close button). When user tabbing through modal elements focusable will be only modal elements, while user click close button.
Tickets / Documentation
Ticket
Screenshots (if appropriate)
product_details_modal_trap.zip