Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(storefront) BCTHEME-224: change role for sort-by select on listbox #1837

Merged
merged 2 commits into from
Oct 2, 2020
Merged

fix(storefront) BCTHEME-224: change role for sort-by select on listbox #1837

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b828e4f
fix(storefront)BCTHEME-224: change role for sort by select
bc-alexsaiannyi Sep 11, 2020
e9cebd4
Merge branch 'master' into bctheme-224
BC-tymurbiedukhin Oct 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Changelog

## Draft
- Fixed announcement of SortBy Select to listbox from button via screen reader. [#1837](https://github.com/bigcommerce/cornerstone/pull/1837)
- Fixed missing top outline on chosen filter's focused. [#1829](https://github.com/bigcommerce/cornerstone/pull/1829)
- Added immediate keyboard focus on write-a-review modal. [#1835](https://github.com/bigcommerce/cornerstone/pull/1835)
- Fixed VoiceOver focus is not sync with keyboard focus on Faceted Search.[#1826](https://github.com/bigcommerce/cornerstone/pull/1826)
Expand Down
7 changes: 6 additions & 1 deletion templates/components/amp/products/options/set-select.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,12 @@
{{/if}}
</label>

<select class="form-select form-select--small" name="attribute[{{this.id}}]" id="attribute_{{id}}" {{#if required}}required{{/if}}>
<select
class="form-select form-select--small"
name="attribute[{{this.id}}]"
id="attribute_{{id}}"
role="listbox"
{{#if required}}required{{/if}}>
<option value="">{{lang 'products.choose_options'}}</option>
{{#each this.values}}
<option data-product-attribute-value="{{id}}" value="{{id}}" {{#if selected}}selected{{/if}}>{{label}}</option>
Expand Down
2 changes: 1 addition & 1 deletion templates/components/category/sort-box.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<fieldset class="form-fieldset actionBar-section">
<div class="form-field">
<label class="form-label" for="sort">{{lang 'common.sorter.sort_by'}}</label>
<select class="form-select form-select--small" name="sort" id="sort">
<select class="form-select form-select--small " name="sort" id="sort" role="listbox">
<option value="featured" {{#if sort '==' 'featured'}}selected{{/if}}>{{lang 'common.sorter.featured'}}</option>
<option value="newest" {{#if sort '==' 'newest'}}selected{{/if}}>{{lang 'common.sorter.newest'}}</option>
<option value="bestselling" {{#if sort '==' 'bestselling'}}selected{{/if}}>{{lang 'common.sorter.top_sellers'}}</option>
Expand Down