Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(storefront): BCTHEME-164 Fix image in modal for IE11 #1840

Merged
merged 2 commits into from
Oct 21, 2020
Merged

fix(storefront): BCTHEME-164 Fix image in modal for IE11 #1840

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e80a729
fix(storefront)BCTHEME-164: fix image in modal for IE11
bc-alexsaiannyi Sep 15, 2020
9a21ed1
Merge branch 'master' into bctheme-164
BC-tymurbiedukhin Oct 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Changelog

## Draft
- Fixed image in modal for IE. [#1840](https://github.com/bigcommerce/cornerstone/pull/1840)
- Create unified focus styling in Cornerstone. [#1812](https://github.com/bigcommerce/cornerstone/pull/1812)
- Review link in quick modal focused twice. [#1797](https://github.com/bigcommerce/cornerstone/pull/1797)
- Fixed product image doesn't change on click when viewing a product with multiple images in IE11 [#1748](https://github.com/bigcommerce/cornerstone/pull/1748)
Expand Down
2 changes: 0 additions & 2 deletions assets/js/theme/global.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ import adminBar from './global/adminBar';
import carousel from './common/carousel';
import loadingProgressBar from './global/loading-progress-bar';
import svgInjector from './global/svg-injector';
import objectFitImages from './global/object-fit-polyfill';

export default class Global extends PageManager {
onReady() {
Expand All @@ -36,6 +35,5 @@ export default class Global extends PageManager {
}
loadingProgressBar();
svgInjector();
objectFitImages();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we be sure that it wont affect any new issues, I believe in some time it was fix for another problem

}
}
5 changes: 0 additions & 5 deletions assets/js/theme/global/object-fit-polyfill.js
View file
Open in desktop

This file was deleted.