Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storefront): BCTHEME-288 Shoppers are not anchor-linked to reviews on PDPs if product description tabs are enabled #1883

Merged
merged 2 commits into from
Nov 17, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Changelog

## Draft
- Shoppers are not anchor-linked to reviews on PDPs if product description tabs are enabled. [#1883](https://github.com/bigcommerce/cornerstone/pull/1883)
- Fixed text contrast for brand name on Cart page. [#1882](https://github.com/bigcommerce/cornerstone/pull/1882)
- Add sufficient contrast for Upsell Banners in Cornerstone Theme according to AA Standard. [#1891](https://github.com/bigcommerce/cornerstone/pull/1891)
- Add appropriate text contrast for "Skip to Main Content". [#1880](https://github.com/bigcommerce/cornerstone/pull/1880)
Expand Down
2 changes: 1 addition & 1 deletion assets/js/theme/product/reviews.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export default class {
initLinkBind() {
const $content = $('#productReviews-content', this.$reviewsContent);

$('.productView-reviewLink').on('click', () => {
$('#productReview_link').on('click', () => {
$('.productView-reviewTabLink').trigger('click');
if (!$content.hasClass('is-open')) {
this.$collapsible.trigger(CollapsibleEvents.click);
Expand Down
2 changes: 1 addition & 1 deletion templates/components/products/product-view.html
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ <h2 class="productView-brand"{{#if schema}} itemprop="brand" itemscope itemtype=
{{> components/products/ratings rating=product.rating}}
</span>
{{#if product.num_reviews '>' 0}}
<a href="{{product.url}}#product-reviews" class=" ">
<a href="{{product.url}}#product-reviews" id="productReview_link">
{{lang 'products.reviews.link_to_review' total=product.num_reviews}}
</a>
{{else}}
Expand Down