Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ES-2031 display error message when star search fails with prod filtering enabled #2005

Merged
merged 4 commits into from
Mar 11, 2021
Merged

ES-2031 display error message when star search fails with prod filtering enabled #2005

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b67ec1a
fix(search): ES-2031 add error message for when star search is not av…
bc-nataliya Mar 1, 2021
cbc0515
feat(search): ES-1590 render error msg for brand page
kvnwang Mar 2, 2021
4e7bfea
fix(search): ES-2031 make search error more generic
kvnwang Mar 4, 2021
161d8d7
feat(search): ES-2031 add change to changelog
kvnwang Mar 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
- Added unique identifiers to product cards on product list pages. [#1999](https://github.com/bigcommerce/cornerstone/pull/1999)
- Fixed line breaks on Dropdown menu display mode. [#1996](https://github.com/bigcommerce/cornerstone/pull/1996)
- Added notifications on Carousel's content cahnge through 'Next/Prev' buttons. [#1986](https://github.com/bigcommerce/cornerstone/pull/1986)
- Add error message when faceted search fails on search, category, brand pages [#2005](https://github.com/bigcommerce/cornerstone/pull/2005)

## 5.2.0 (02-22-2021)
- Fixed cut off on Cart button when Zooming up to 400%. [#1988](https://github.com/bigcommerce/cornerstone/pull/1988)
Expand Down
2 changes: 1 addition & 1 deletion lang/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -826,7 +826,7 @@
"state_error": "There was a problem retrieving states/provinces"
},
"search": {
"errorMessage": "There was a problem retrieving your search results. Please try again in a few seconds, or try a different search.",
"errorMessage": "There was a problem retrieving your results. Please try again in a few seconds.",
"quick_search": {
"input_label": "Search",
"input_placeholder": "Search the store"
Expand Down
18 changes: 11 additions & 7 deletions templates/components/category/product-listing.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,15 @@

{{> components/common/paginator pagination.category}}
{{else}}
<p data-no-products-notification
role="alert"
aria-live="assertive"
tabindex="-1"
>
{{lang 'categories.no_products'}}
</p>
{{#if category.search_error}}
<p>{{lang 'search.errorMessage'}}</p>
{{else}}
<p data-no-products-notification
role="alert"
aria-live="assertive"
tabindex="-1"
>
{{lang 'categories.no_products'}}
</p>
{{/if}}
{{/if}}
12 changes: 8 additions & 4 deletions templates/pages/brand.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,16 @@ <h1 class="page-heading">{{brand.name}}</h1>
</aside>

<main class="page-content" id="product-listing-container">
{{#if brand.products}}
{{> components/brand/product-listing}}
{{#if brand.search_error }}
<p>{{lang 'search.errorMessage'}}</p>
{{else}}
<p>{{lang 'brands.no_products'}}</p>
{{#if brand.products}}
{{> components/brand/product-listing}}
{{else}}
<p>{{lang 'brands.no_products'}}</p>
{{/if}}
{{{region name="brand_below_content"}}}
{{/if}}
{{{region name="brand_below_content"}}}
</main>
</div>

Expand Down